fix: align sales form colors with website semantic tokens#2876
fix: align sales form colors with website semantic tokens#2876
Conversation
- Update Textarea component to use semantic tokens (border-line-structure, bg-surface-bg, ring-line-cta, etc.) instead of old shadcn defaults (border-input, bg-background, ring-ring) which resolve to blueish-grey - Update checkbox container border from border-input to border-line-structure - Add accent-line-cta to native checkboxes so checked state uses the site's CTA color instead of browser-default blue - Align border-radius to rounded-[2px] to match Input and Select components Co-authored-by: felixkrrr <felixkrrr@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@claude review |
There was a problem hiding this comment.
LGTM, straightforward styling alignment to semantic design tokens.
Extended reasoning...
Overview
This PR updates two files (components/ContactSalesForm.tsx and components/ui/textarea.tsx) to swap old shadcn default color tokens (border-input, bg-background, ring-ring, text-muted-foreground) for the site's warm-grey semantic tokens (border-line-structure, bg-surface-bg, ring-line-cta, text-text-disabled). Border radius is also normalized to rounded-[2px] and native checkboxes get accent-line-cta so checked state matches the site's CTA color.
Security risks
None. The changes are purely Tailwind utility class swaps with no logic, no data flow, no auth/crypto/permissions implications.
Level of scrutiny
Very low. This is a presentation-only XS-sized PR (the label confirms this) that mechanically replaces one set of design tokens with another to align with the broader site styling. No behavioral change, no new dependencies, no API surface affected.
Other factors
The bug hunting system found no issues. The diff is small, self-contained, and the new tokens (border-line-structure, bg-surface-bg, ring-line-cta, text-text-disabled, text-text-secondary) match the patterns already used by sibling components like Input and SelectTrigger per the PR description. Vercel preview build succeeded.
- Replace default 'border' (blueish-grey --border variable) with 'border border-line-structure' on video tab content panels - Add corner-box-corners for consistent decorative brackets matching CTA boxes and other site elements - Align iframe border-radius to rounded-[2px] for consistency Co-authored-by: felixkrrr <felixkrrr@users.noreply.github.com>
- Add 'relative' so corner-box-corners pseudo-element is contained within the video card instead of escaping to a page-level ancestor - Add 'rounded-none' to override the base TabsContent rounded-b-lg that caused mismatched bottom border radius Co-authored-by: felixkrrr <felixkrrr@users.noreply.github.com>
The base TabsContent has overflow-hidden which clips the corner-box-corners pseudo-element that sits at -1px inset. Add overflow-visible to override. Co-authored-by: felixkrrr <felixkrrr@users.noreply.github.com>
Problem
The sales/contact form and video embed pages had inconsistent coloring — several elements used blueish-grey colors from old shadcn defaults (
border-input,bg-background,ring-ring, defaultborder) instead of the site's warm-grey semantic tokens.Specifically:
/watch-demohad blueish-grey borders from the defaultborderclassChanges
components/ui/textarea.tsxReplaced old shadcn tokens with the site's semantic design tokens to match
InputandSelectTrigger:border-input→border-line-structurebg-background→bg-surface-bgring-ring/ring-offset-background→ring-line-cta/ring-offset-surface-bgplaceholder:text-muted-foreground→placeholder:text-text-disabledrounded→rounded-[2px](consistent with Input/Select)text-text-secondaryandshadow-smcomponents/ContactSalesForm.tsxborder-input→border-line-structure,rounded-md→rounded-[2px]accent-line-ctaso checked state uses the site's CTA color, changed border toborder-line-structurecomponents/watchOrBookDemo/WatchWalkthroughs.tsxborder(blueish-grey--bordervariable) withborder border-line-structurecorner-box-cornersfor consistent decorative bracket corners matching CTA boxesroundedin favor of the corner-box stylerounded-[2px]Resolves LFE-9413
Linear Issue: LFE-9413
Disclaimer: Experimental PR review
Greptile Summary
This PR aligns the
/talk-to-ussales form's textarea and checkbox elements with the site's warm-grey semantic design tokens, replacing leftover shadcn defaults (border-input,bg-background,ring-ring) to match howInputandSelectTriggerare already styled. The changes are cosmetic-only and well-scoped.Confidence Score: 4/5
Safe to merge — purely cosmetic token swap with no logic changes.
Only P2 findings: a slightly reduced focus ring in textarea and no-op border/radius classes on a native checkbox. No logic, data, or security concerns.
No files require special attention; both changes are isolated styling updates.
Important Files Changed
accent-line-ctafor checked state colour;border-line-structure/rounded-[2px]on the native checkbox input are inert withoutappearance: nonebut harmless.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["Textarea / Checkbox render"] --> B{"Token source"} B -->|"Before (shadcn defaults)"| C["border-input\nbg-background\nring-ring\nring-offset-background\nplaceholder:text-muted-foreground"] B -->|"After (semantic tokens)"| D["border-line-structure\nbg-surface-bg\nring-line-cta\nring-offset-surface-bg\nplaceholder:text-text-disabled\naccent-line-cta"] D --> E["Consistent warm-grey styling\nmatches Input & SelectTrigger"]Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "fix: align sales form colors with websit..." | Re-trigger Greptile